kayprish/mandelbrot-visualiser
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix thread argument error #1

Merged
kayprish merged 2 commits from brk/mandelbrot-visualiser:master into master 2025-10-24 08:11:12 +02:00
Conversation 1 Commits 2 Files changed 1 +1 -1
brk commented 2025-10-23 22:54:05 +02:00
Contributor
Copy link

After starting the visor with a thread argument, I get:

(visor:10227): GLib-GIO-CRITICAL **: 22:35:08.239: This application can not open files.

Seems like GTK is trying to parse this argument as a file, and tries to open it.
This is a hacky way to fix an issue, yes, but if you don't plan to add GTK related arguments, or arguments that aren't passed before g_application_run(...), I think tricking this function that only ./visor is called is probably fine.

After starting the visor with a thread argument, I get: ```bash (visor:10227): GLib-GIO-CRITICAL **: 22:35:08.239: This application can not open files. ``` Seems like GTK is trying to parse this argument as a file, and tries to open it. This is a hacky way to fix an issue, yes, but if you don't plan to add GTK related arguments, or arguments that aren't passed before `g_application_run(...)`, I think tricking this function that only .`/visor` is called is probably fine.
brk added 1 commit 2025-10-23 22:54:05 +02:00
requested review from kayprish 2025-10-23 22:54:13 +02:00
kayprish added 1 commit 2025-10-24 07:57:28 +02:00
kayprish commented 2025-10-24 08:10:50 +02:00
Owner
Copy link

Thanks for the fix, accepted with minor stylistic change (apparently the GTK docs recommend to pass NULL, if you want the command line arguments to be ignored).

Thanks for the fix, accepted with minor stylistic change (apparently the GTK docs recommend to pass `NULL`, if you want the command line arguments to be ignored).
kayprish merged commit 6ef8002f08 into master 2025-10-24 08:11:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
kayprish
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: kayprish/mandelbrot-visualiser#1
No description provided.
Delete branch "brk/mandelbrot-visualiser:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?